Add Massactions Validate/Cancel/RegeneratePDF/MergePDF/EditStartDate/EditeEndDate on Mo List #33548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Mar 20, 2025
htdocs/mrp/mo_list.php
Outdated
| @@ -207,6 +217,76 @@ | |||
| $objectlabel = 'Mo'; | |||
| $uploaddir = $conf->mrp->dir_output; | |||
| include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php'; | |||
| $objMo = new Mo($db); | |||
|
|
|||
| if($action == 'confirm_cancel') { | |||
There was a problem hiding this comment.
You should install the precommit github hook so this king of CI error are automatically fixed.
eldy
added
the
PR to fix - Conflict or CI error to solve
|
@eldy 👍 |
eldy
reviewed
Apr 1, 2025
htdocs/mrp/mo_list.php
Outdated
| @@ -207,6 +217,74 @@ | |||
| $objectlabel = 'Mo'; | |||
| $uploaddir = $conf->mrp->dir_output; | |||
| include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php'; | |||
| $objMo = new Mo($db); | |||
|
|
|||
| if ($action == 'confirm_cancel' && $confirm == 'yes') { | |||
There was a problem hiding this comment.
There is a CI error here becasue you executed an action without doing any test on permission.
Try to replace with
if ($action == 'confirm_cancel' && $confirm == 'yes' && $permissiontoadd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Massactions to the standard OF list: