Merge remote-tracking branch 'upstream/develop' into mailing

.github/workflows/ci-on-pull_request.yml

@@ -0,0 +1,41 @@
+name: "CI"
+
+on: [pull_request]
+jobs:
+  pre-commit:
+    uses: ./.github/workflows/pre-commit.yml
+    secrets: inherit
+    with:
+      gh_event: ${{ github.event_name }}
+  phan:
+    uses: ./.github/workflows/phan.yml
+    secrets: inherit
+    needs: [pre-commit]
+    with:
+      gh_event: ${{ github.event_name }}
+  phpstan:
+    uses: ./.github/workflows/phpstan.yml
+    secrets: inherit
+    needs: [pre-commit]
+    with:
+      gh_event: ${{ github.event_name }}
+  #windows-ci:
+  #  needs: [pre-commit, phan, phpstan]
+  #  secrets: inherit
+  #  uses: ./.github/workflows/windows-ci.yml
+  #  with:
+  #    gh_event: ${{ github.event_name }}
+  gh-travis:  # Runs travis script on github runner (not on travis)
+    if: false
+    # needs: [pre-commit, phan]
+    # needs: [windows-ci]
+    secrets: inherit
+    needs: [pre-commit, phan, phpstan]
+    uses: ./.github/workflows/gh-travis.yml
+    with:
+      gh_event: ${{ github.event_name }}
+
+# Note (not tested, from https://github.com/orgs/community/discussions/38361)
+# To cancel jobs if one fails, the following action may help
+#       - if: "failure()"
+#        uses: "andymckay/[email protected]"

.github/workflows/ci.yml → .github/workflows/ci-on-push.yml

@@ -1,6 +1,6 @@
 name: "CI"
 
-on: [push, pull_request]
+on: [push]
 jobs:
   pre-commit:
     uses: ./.github/workflows/pre-commit.yml
@@ -20,7 +20,7 @@ jobs:
     with:
       gh_event: ${{ github.event_name }}
   windows-ci:
-    needs: [pre-commit, phpstan, phan]
+    needs: [pre-commit, phan, phpstan]
     secrets: inherit
     uses: ./.github/workflows/windows-ci.yml
     with:
@@ -30,11 +30,11 @@ jobs:
     # needs: [pre-commit, phan]
     # needs: [windows-ci]
     secrets: inherit
+    needs: [pre-commit, phan, phpstan]
     uses: ./.github/workflows/gh-travis.yml
     with:
       gh_event: ${{ github.event_name }}
 
-
 # Note (not tested, from https://github.com/orgs/community/discussions/38361)
 # To cancel jobs if one fails, the following action may help
 #       - if: "failure()"

.github/workflows/gh-travis.yml

@@ -3,13 +3,13 @@
 name: Travis
 # Controls when the workflow will run
 on:
-  # push:
-  # pull_request:
+  # workflow called by the parent workflow ci.yml
   workflow_call:
     inputs:
       gh_event:
         required: true
         type: string
+  # can run job manually
   workflow_dispatch:
 
 concurrency:

.github/workflows/phan.yml

@@ -1,15 +1,12 @@
 ---
 on:
-  # pull_request:
-  # push:
-  # schedule:
-  #   # execute once a day, the 1st
-  #   - cron: 10 9 * * *
+  # workflow called by the parent workflow ci.yml
   workflow_call:
     inputs:
       gh_event:
         required: true
         type: string
+  # can run job manually
   workflow_dispatch:
 
 concurrency:

.github/workflows/phpstan.yml

@@ -3,18 +3,17 @@
 name: PHPStan
 # Controls when the workflow will run
 on:
-  # push:
-  # pull_request:
+  # workflow called by the parent workflow ci.yml
   workflow_call:
     inputs:
       gh_event:
         required: true
         type: string
+  # can run job manually
   workflow_dispatch:
 
 concurrency:
-  group: stan-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref
-    }}
+  group: stan-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 env:
   gh_event: ${{ inputs.gh_event || github.event_name }}

.github/workflows/pre-commit.yml

@@ -1,13 +1,13 @@
 ---
 name: pre-commit
 on:
-  # pull_request:
-  # push:
+  # workflow called by the parent workflow ci.yml
   workflow_call:
     inputs:
       gh_event:
         required: true
         type: string
+  # can run job manually
   workflow_dispatch:
 
 concurrency:

.github/workflows/windows-ci.yml

@@ -2,13 +2,13 @@
 name: Win CI
 # yamllint disable-line rule:truthy
 on:
-  # push:
-  # pull_request:
+  # workflow called by the parent workflow ci.yml
   workflow_call:
     inputs:
       gh_event:
         required: true
         type: string
+  # can run job manually
   workflow_dispatch:
 
 concurrency: