Skip to content

fix: Improve release tag extraction to avoid issues with some curl version #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theoDep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Improve release tag extraction to avoid issues with some curl version #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apps/website/public/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ detect_version() {
echo "Detecting latest stable version from GitHub..." >&2

# Try to get latest release from GitHub by following redirects
version=$(curl -fsSL -o /dev/null -w '%{url_effective}\n' \
https://github.com/dokploy/dokploy/releases/latest 2>/dev/null | \
sed 's#.*/tag/##')
effective_url=$(curl -fsSL -o /dev/null -w '%{url_effective}\n' \
https://github.com/dokploy/dokploy/releases/latest 2>/dev/null)

# Fallback to latest tag if detection fails
if [ -z "$version" ]; then
# Extract tag from URL (format: .../releases/tag/v0.x.x)
if echo "$effective_url" | grep -q '/tag/'; then
version=$(echo "$effective_url" | sed 's#.*/tag/##')
fi

# Validate version looks like a tag (starts with 'v' or is a valid semver)
if [ -z "$version" ] || echo "$version" | grep -q '^http'; then
echo "Warning: Could not detect latest version from GitHub, using fallback version latest" >&2
version="latest"
else
Expand Down