Skip to content

fix: Replace tooltip trigger button for help icon (provider compose ui)#3902

Open
naturedamends wants to merge 6 commits intoDokploy:canaryfrom
naturedamends:patch-1
Open

fix: Replace tooltip trigger button for help icon (provider compose ui)#3902
naturedamends wants to merge 6 commits intoDokploy:canaryfrom
naturedamends:patch-1

Conversation

@naturedamends
Copy link

@naturedamends naturedamends commented Mar 5, 2026

This is only in one provider but can be extened to other providers

What is this PR about?

Prevents from defaulting to trigger a form submit action on click

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • [x. doing it now] You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • [nope, there are other providers that need to be done] You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #123

Screenshots (if applicable)

Greptile Summary

This PR fixes a real bug where <TooltipTrigger> without asChild would default to type="submit" inside a form, causing unintended form submissions when the help icon is clicked. The fix replaces the div-based trigger with a proper <button type="button"> and adds asChild to the trigger.

Critical issues found:

  • Missing import: HelpCircle from lucide-react is used on line 417 but not imported. The lucide-react import on line 2 must be updated to include HelpCircle.
  • Indentation: The new <button> block uses mixed spaces and tabs, breaking the file's tab-based indentation consistency.
  • EDIT @naturedamends : DONE

Confidence Score: 1/5

  • Not safe to merge — missing HelpCircle import will cause a build failure.
  • The PR introduces a build-breaking error: HelpCircle is used on line 417 but not imported from lucide-react. Additionally, the new button block uses inconsistent indentation (mixed spaces and tabs). Both issues must be resolved before merging.
  • apps/dokploy/components/dashboard/compose/general/generic/save-gitea-provider-compose.tsx (missing import and indentation)

Comments Outside Diff (1)

  1. apps/dokploy/components/dashboard/compose/general/generic/save-gitea-provider-compose.tsx, line 2 (link)

    HelpCircle is used on line 417 but is never imported in this file. The existing lucide-react import on line 2 only includes { CheckIcon, ChevronsUpDown, Plus, X }. This will cause a build error.

    Update the import to include HelpCircle:

Last reviewed commit: 453a7b1

Greptile also left 1 inline comment on this PR.

(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

Context used:

  • Rule from dashboard - AGENTS.md (source)

This is only in one provider but can be extened to other providers
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 5, 2026
@dosubot
Copy link

dosubot bot commented Mar 5, 2026

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

naturedamends and others added 2 commits March 5, 2026 20:33
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@naturedamends naturedamends changed the title Replace tooltip trigger with button for help icon feat (compose): Replace tooltip trigger with button for help icon Mar 5, 2026
@naturedamends naturedamends changed the title feat (compose): Replace tooltip trigger with button for help icon feat(compose): Replace tooltip trigger with button for help icon Mar 5, 2026
@naturedamends naturedamends changed the title feat(compose): Replace tooltip trigger with button for help icon feat: Replace tooltip trigger with button for help icon (compose) Mar 5, 2026
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 5, 2026
@naturedamends naturedamends changed the title feat: Replace tooltip trigger with button for help icon (compose) feat: Replace tooltip trigger button for help icon (provider compose ui) Mar 5, 2026
@naturedamends naturedamends changed the title feat: Replace tooltip trigger button for help icon (provider compose ui) fix: Replace tooltip trigger button for help icon (provider compose ui) Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant