feat(backups): support FTP/SFTP/GDrive/OneDrive rclone destinations#3874
Open
yuliuyi717-ux wants to merge 1 commit intoDokploy:mainfrom
Open
feat(backups): support FTP/SFTP/GDrive/OneDrive rclone destinations#3874yuliuyi717-ux wants to merge 1 commit intoDokploy:mainfrom
yuliuyi717-ux wants to merge 1 commit intoDokploy:mainfrom
Conversation
Author
|
Quick review request on this PR. Current checks are passing, and I can provide extra validation details or adjust implementation quickly if needed. |
Author
|
Following up on #3874. The rclone destination support (FTP/SFTP/GDrive/OneDrive) is implemented and I can make any requested changes promptly. Would appreciate a review when possible. |
|
Friendly ping! This PR is ready for review. All checks have passed (anti-slop ✓). Happy to address any feedback! |
0bb0682 to
f2493a3
Compare
Author
|
Quick check-in for this PR. Implementation is ready from my side and I’m waiting on maintainer review. Please let me know if you want any adjustments and I’ll patch promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #416
This PR adds a focused, incremental implementation to support additional rclone destination types while keeping existing S3 behavior intact.
What changed:
apps/dokploy/__test__/utils/backups.test.tsWhy this approach:
Validation notes:
apps/dokploy/__test__/utils/backups.test.tsnode_modulesmissing) and repository requires Node^24.4.0while current environment is Node22.x.I can follow up with a second PR for richer provider-specific UX (advanced fields / token refresh workflows) if this incremental backend-compatible approach looks good.
Greptile Summary
This PR adds support for FTP, SFTP, Google Drive, and OneDrive as rclone backup destinations alongside existing S3. The implementation is well-structured:
Strengths:
getRcloneDestination,getRclonePrefixPath,getS3Credentials) cleanly abstract destination paths and credential handlingApproach is sound:
The generalized helpers are reused across all backup modules, reducing duplication and making future provider additions straightforward. The pattern is consistent and maintainable.
No blocking issues identified.
Confidence Score: 4/5
Last reviewed commit: 0bb0682
(2/5) Greptile learns from your feedback when you react with thumbs up/down!
Context used:
dashboard- AGENTS.md (source)