DOJ-4810: give workbook-generate creative latitude (kit as vocabulary, not script)#28
Conversation
…, not script) Guidance-only rebalance (skill + command); no template/architecture change. V1 optimized for consistency/reliability — this leaves room for concept-specific creativity without touching the invariants (brand, a11y, nav, standalone). - content->component mapping reframed as heuristics + explicit anti-monotony - new "Invariant frame vs creative payload" section: lock brand/a11y/nav/ standalone; vary prose, what diagrams depict, component choice/composition - "kit is a floor, not a ceiling" — author bespoke inline SVG/CSS freely; narrow the JS anti-pattern to fragile *stateful* widgets only (not a ban on static/SVG/CSS creativity) - Phase 4.5 variety/fit self-check before saving - "monotony" added as an explicit anti-pattern No workbook-base.html change. CI lint green; voice-neutral. Created by Claude Code on behalf of @daniel Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@dojo-code-reviewer review |
![dojo-code-reviewer[bot]](https://avatars.githubusercontent.com/in/3092887?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Approved
Approved — no findings. Confidence: 5/5. NITs: 2 (shown).
⚪ P4 — Nitpicks
-
commands/workbook-generate.md:109— [NIT] ⚪ P4 (nit) — Unnecessary backslash escaping of double quotes in Markdown. Standard double quotes render perfectly without escaping. -
skills/workbook-generate/SKILL.md:323— [NIT] ⚪ P4 (nit) — Escaped backslashes are unnecessary inside plain Markdown files. Standard double quotes can be used directly without escaping.
Total findings: 2 nit (2 total)
| SVG/CSS within the design tokens + a11y contract). Reserve the "compose from the | ||
| tested kit" discipline for fragile *stateful JS* — static/SVG/CSS creativity is | ||
| encouraged. Interactivity must earn its place; prefer one well-chosen block per | ||
| concept over decorative ones. See the skill's "Invariant frame vs. creative |
There was a problem hiding this comment.
[NIT] ⚪ P4 (nit) — Unnecessary backslash escaping of double quotes in Markdown. Standard double quotes render perfectly without escaping.
| stateful interactivity from the tested kit, and extend the kit deliberately | ||
| (with tests) when a concept truly needs a new interaction. (This is *not* a | ||
| ban on creative static / SVG / CSS visualization — author those freely; see | ||
| "The kit is a floor, not a ceiling.") |
There was a problem hiding this comment.
[NIT] ⚪ P4 (nit) — Escaped backslashes are unnecessary inside plain Markdown files. Standard double quotes can be used directly without escaping.
1 participant
Summary
Guidance-only follow-up to DOJ-4798 (shipped). V1 of
workbook-generateoptimized hard for consistency/reliability — curated component kit, single base template, content→component mapping. That's the right reliable/accessible/on-brand floor, but it risks monotony if the kit is treated as a script instead of a vocabulary. This rebalances the guidance only (skill + command prose) to leave room for concept-specific creativity — without touching the invariants (brand tokens, accessibility contract, navigation/flow shell, standalone/no-CDN) or the template.Changes (skill + command only — no
workbook-base.htmlchange)Out of scope
workbook-base.html(template/runtime), brand/a11y/nav rules, dojo-academy spec — all unchanged.Test plan
check_frontmatter/check_agent_references/check_json_schemas)git statusconfirms onlyskills/workbook-generate/SKILL.md+commands/workbook-generate.mdchangedCloses DOJ-4810
Created by Claude Code on behalf of @dbejarano820
🤖 Generated with Claude Code