feat: add --notify NONE for thread replies - #62
Merged
Merged
Conversation
doistbot
reviewed
Sep 15, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR adds a NONE sentinel for --notify on thread replies, wired consistently through the reply, close, and reopen paths with empty recipient/group/mention lists, plus dry-run preview output (Notify: NONE), help text, completion choices, README, and SKILL_CONTENT/skill file updates kept in sync. No inline issues were flagged — the implementation reuses the existing notify helpers, keeps authorization checks unconditional, and is well covered by new tests.
I also left one optional follow-up note in the details below.
Optional follow-up note (1)
src/commands/thread/thread.test.ts:449:
preserves existing recipients for $notifyre-runs the same six recipient modes against all three actions (18 cases), even though the ID-resolution andnotificationFieldsconstruction are shared acrossreply/close/reopenand the action-specific spread is already exercised by the--notify NONEtests. Consolidate: keep the six-mode matrix onreplyonly, and add one representative non-empty case (e.g.123,id:group1) forcloseandreopento confirm non-emptyrecipients/groupsstill reach those methods.
scottlovegrove
approved these changes
Sep 15, 2026
doist-release-bot Bot
added a commit
that referenced
this pull request
Sep 15, 2026
## [3.2.0](v3.1.0...v3.2.0) (2026-09-15) ### Features * add --notify NONE for thread replies ([#62](#62)) ([9e95c8d](9e95c8d))
Contributor
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
--notify NONEto post a thread reply without notifying anyone, including replies that close or reopen the thread. The default remainsEVERYONE_IN_THREAD, and existing user/group recipients keep their current behavior.Changes
Notify: NONEin dry-run previews and document the option in help, shell completion, and the generated agent skill.Test plan
node dist/index.js thread reply <thread-ref> "Quiet update" --notify NONE --dry-run. Check that the preview showsNotify: NONEand no comment is posted.--closeand--reopen. Check that the preview shows the intended thread action and still showsNotify: NONE.--notifyand check that the preview showsEVERYONE_IN_THREAD. Try explicit user/group IDs and check that the preview names the intended recipients.