Skip to content

fix(release): update release env name #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SafeEval merged 2 commits into from
Aug 24, 2025
Merged

fix(release): update release env name #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702304b
Pass ECR URL as argument
SafeEval Aug 24, 2025
1700dc7
Update release env to release-ecr
SafeEval Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
group: ${{ github.workflow }}-release-${{ github.ref_name }}
cancel-in-progress: false
environment:
name: release
name: release-ecr

steps:
# Use a merge queue to avoid `main` commit race conditions.
Expand All @@ -39,4 +39,4 @@ jobs:
run: uv run task build

- name: Release (ECR)
run: uv run task release-ecr-no-build
run: uv run task release-ecr-no-build {{.ECR_REPOSITORY_URL}}
6 changes: 4 additions & 2 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ vars:
DOCKER_IMAGE_TAG:
sh: ./scripts/get-version.sh
DOCKER_IMAGE: "{{.DOCKER_IMAGE_NAME}}:{{.DOCKER_IMAGE_TAG}}"
ECR_REPOSITORY_URL:
sh: echo $ECR_REPOSITORY_URL

tasks:
default:
Expand Down Expand Up @@ -83,10 +85,10 @@ tasks:
deps:
- build
cmds:
- ./scripts/release-ecr.sh
- ./scripts/release-ecr.sh {{.ECR_REPOSITORY_URL}}

release-ecr-no-build:
desc: Release the Docker image to ECR without building it first
run: once
cmds:
- ./scripts/release-ecr.sh
- ./scripts/release-ecr.sh {{.ECR_REPOSITORY_URL}}
2 changes: 1 addition & 1 deletion scripts/release-ecr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -euo pipefail

ECR_REPOSITORY_URL="${1:-$ECR_REPOSITORY_URL}"
ECR_REPOSITORY_URL="$1"

IMAGE_NAME="$(echo "$ECR_REPOSITORY_URL" | cut -d '/' -f 2)"
IMAGE_TAG="$(./scripts/get-version.sh)"
Expand Down