Fix rsx evaluation order #3944
Open
Fix rsx evaluation order #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expand dynamic expressions, component, and attributes in different sections of the rsx macro. This can lead to very confusing borrow checker errors where rust complains that a item is borrowed before it is moved which should be valid, but because we shuffle expressions the item ends up being borrowed after it is moved.
This PR fixes that issue by introducing a dynamic expression pool and expanding items in depth first order in that pool before using the bindings in our dynamic node and dynamic attribute pools
Closes #3737