Cell level annotation #207
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR could maybe be divided into multiple PRs. Let me know if you want to. In summary, the changes are:
Allow a flag called
overlappingSuperpixels
in the attribute part of annotation files. If this istrue
(default isfalse
) then masks for the filmstrip and review cards are removed. This is for AML, where bounding boxes for cells often overlap, which means part of the thumbnails will be missing. I defined it in the attributes to avoid having to change all the JSON validation schemas in girder.Support for ignoring background pixels. This is to enable sparse pixelmaps to be defined, where there is empty space between superpixels (in my case, space between white blood cells). Right now it is implemented with a 1 pixel bounding box in the top left corner. If this is found at index 0, then the UI will ignore this (and other clicks in empty areas).
I tried using a cleaner approach where I told the UI to ignore all pixelmap-values which had 0. But this requires changes to several parts of the code, including changes to
large_image
andhistomicstk
. I could start working on this, but for now I just wanted to start simple. In my current commit, the downside is that the background superpixel with a 1 pixel bounding box will show up in the filmstrip and review card, which may confuse the user. I tried hiding it from the UI, but this also requires changes in multiple locations, so I wanted to hear any reviewer's thoughts first.a simple log to the console to fix
getJobXmlUrl
exception is eaten by framework #185Potential error fixes in cases with few superpixels