Add basic enemy colors to minimap #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indy2222
requested changes
Jun 18, 2024
Indy2222
requested changes
Jun 19, 2024
Fixes DigitalExtinction#584 The playable player is still always blue, but all other players are assigned a color based on their player number.
refactor PlayerColors to be easier to re-use
implenting the suggested improvements made the tuple struct faster than the hashmap lookup
Indy2222
reviewed
Jun 20, 2024
|
Also, please note that I have done some important CI related fixes to |
Indy2222
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584.
All players are assigned a color based on their player number. It also changes the color of the units slightly to distinguish them from buildings.
In the future I think it would be nice that each player could choose their color from a list of curated colors that are visually distinctive, and then they would always be consistent across single player or multiplayer views. Or they are assigned a color, but then the UI would need to change in other ways so they would know which color they were assigned. This could be as simple as a color bar next to the their name in the game list, or some other color indicator in the HUD.
I'm just learning Rust and Bevy, so hopefully I did things properly. Let me know if you would like any changes.