Fixed bind command, and added rough vtx implementation #6
Conversation
More ACC_x_ALIGN cleanup
Enabled Multi Gyro on OmnibusF4 Nano V7
Remove deprecated USE_MULTI_GYRO
…r corruption (betaflight#8284) Increase async FAT filesystem cache sectors to prevent blackbox header corruption
…light#8256) Prevent 'system_hse_mhz' from showing in non-F4 'diff'/'dump'.
| ((vtxData->region & 0x01) << 3) | | ||
| ((vtxData->power & 0x07)); | ||
| #if defined(USE_SPEKTRUM_VTX_CONTROL) && defined(USE_VTX_COMMON) | ||
| spektrumHandleVtxControl(vtxControl); |
There was a problem hiding this comment.
That's a good solution, reusing functions makes in more robust in this case.
Really fixed flash erasing.
| @@ -657,6 +691,8 @@ void srxlv2Bind(void) | |||
| .payload = { | |||
| .request = EnterBindMode, | |||
| .device_id = bus_master_device_id, | |||
| .bind_type = DMSX_11ms, | |||
There was a problem hiding this comment.
This was something that puzzled me. Should the bind type hard-coded or we should allow specifying it in CLI?
At first I thought these fields are only used in the GetBindInfo request, and filled by the receiver.
There was a problem hiding this comment.
That's a good point. I think it should be a CLI parameter that defaults to DSMX_11ms, and the "srxlv2_bind" cli command uses the value from that parameter. That way, it should still use this value by default unless the user specifies otherwise. Currently, there should be no need to use anything other than DSMX_11ms for the receivers that will currently support srxlv2.
These fields are used by both requests. For example in a multi receiver system, the FC can GetBindInfo from one receiver, and then send that info to the other receivers so they match the bind state of the initial one, without having to rebind each one.
| @@ -92,7 +92,7 @@ typedef enum { | |||
| } srxlv2BindRequest; | |||
|
|
|||
| typedef enum { | |||
| NotBound = 0xAE, | |||
| NotBound = 0x0, | |||
There was a problem hiding this comment.
Where did 0xAE came from? Did I misinterpret it?
There was a problem hiding this comment.
You had it right based on the documentation, but this was one of the things Matt had to change when fixing the whole bind command implementation. I believe the change was related to some logic required to handle multi receiver systems.
Fixed setting / printing of VAR_UINT32 values.
Fixed printing of reset DMA options in 'diff'.
Add timer info to CLI 'timer' command.
Added selection by alternate function to CLI 'timer'.
Fix VTX chan to 0 via SetFreqByMHz
SPRacingF3NEO - Add BARO support.
…_pins fix adc pins
Fix copy of profiles with last index
…UAL board. (betaflight#8333) TARGET Update: add IIC Baro, SoftSerial, 1G Flash support for EXF722DUAL board.
SPARKY2 Assign correct pins for I2C1
Fix flash m25p16 driver sector erase
…etaflight#8320) Changed 'timer' output to list timers based on alternate function.
[VIVAF4AIO] Fix for non-working ACC
…istance-fix Add minimum descent distance
…at when the flight controller reboots, but the rx is already sending data, sending 0xFF as bus master id will make the receiver request a handshake again. Fixed baud rate toggling when invalid packets are received. Initially, re-connection wouldn't work on 400k baud.
No description provided.