Skip to content

Move Eiger internals from apischema to pydantic #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
callumforrester wants to merge 40 commits into from
Closed

Move Eiger internals from apischema to pydantic #66

callumforrester wants to merge 40 commits into from

Conversation

@callumforrester
Copy link
Contributor

@callumforrester callumforrester commented Jul 24, 2023

No description provided.

abbiemery and others added 30 commits July 14, 2023 13:35
@abbiemery @callumforrester
Merge eiger changes from tickit/Exts-Logic
3811a5f
@abbiemery @callumforrester
Add test to flag missing __init__.py files in tickit directory
3029c7b
@callumforrester
Adapt to WIP Http Adapter PR
5fe979d
@callumforrester
Fix tests
c870cfb
@callumforrester
Begin removing private calls from tests
c67db3e
@callumforrester
Remove unused test
0a8402e
@callumforrester
Add logging to eiger trigger
f4ad5fd
@callumforrester
Add eiger launch config
4a5dd9e
@callumforrester
Fix eiger adapter logging
495ff65
@callumforrester
Ensure interrupts in correct place
df7982b
@callumforrester
Rationalise stream messages into a schema
b9b2e0b
@callumforrester
Move serailization logic out of stream and into adapter
b8925fc
@callumforrester
Complete eiger tests
5238996
@callumforrester
Restructure to remove multiple inheritance
3453611
@callumforrester
Add multi series tests
04cb9ed
@callumforrester
Add exts mode support
2de99c3
@callumforrester
Enable system tests
353b006
@callumforrester
Remove inspector class
ce40080
@callumforrester
Tidy up eiger system test
e186dc4
@callumforrester
Tidy eiger docstrings
ac4ea9a
@callumforrester
Add timeouts to eiger system tests
19a6bff
@callumforrester
Move rest logic out of eiger device
ab2f095
@callumforrester
Fix imports and formatting
298fea0
@callumforrester
Fix mock stream mypy errors
0617352
@callumforrester
Depend on latest tickit again
e24721c
@callumforrester
Fix synchrotron making IOC with args in the wrong order
65f7cec
@callumforrester
Delete package structure test
339b315
@callumforrester
Add docstrings to eiger schema docs
dcd9c04
@callumforrester
Add docstrings to stream
0556f65
@callumforrester
Require pydantic v2
d42ea93
@callumforrester callumforrester mentioned this pull request Jul 24, 2023
Merged
callumforrester pushed a commit that referenced this pull request Jul 24, 2023
@abbiemery
Eiger exts logic (#54)
1cba0a4 
Fixes #53

Changes:

Refactor Eiger detector logic for improved readability
Convert some de/serialization from apischema to pydantic, more work to be done here in #66
Improve eiger tests, including system tests
Add and test EXTS mode support
@callumforrester
Copy link
Contributor Author

callumforrester commented Jul 24, 2023

Closing in favour of #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callumforrester @abbiemery @DiamondJoseph