fix(ci): make devtools dispatch best-effort in publish-openapi-spec#293
Merged
Conversation
A present-but-unauthorised DEVTOOLS_DISPATCH_TOKEN (e.g. a fine-grained PAT pending org approval) made the dispatch step 403 and failed the whole publish run, even though the canonical spec commit - the critical output - succeeded. The notification is best-effort (devtools also syncs on schedule and manually), so a failed dispatch now warns instead of failing the workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #292. The first post-merge
Publish OpenAPI specrun committed the canonical spec correctly but then failed on theNotify smartem-devtoolsstep: theDEVTOOLS_DISPATCH_TOKENis present but pending org approval, sogh api .../dispatchesreturns 403.The notification is a best-effort nudge — the spec commit is the critical output, and smartem-devtools also syncs on a daily schedule and via manual
workflow_dispatch. A failed dispatch should therefore warn, not fail the workflow. The previous guard only handled an absent token, not a present-but-unauthorised one.No functional change once the token is approved; this just stops a transient/pending-token state from reding
main.