Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
==========================================
+ Coverage 49.62% 50.29% +0.67%
==========================================
Files 96 96
Lines 10130 10070 -60
Branches 1331 1320 -11
==========================================
+ Hits 5027 5065 +38
+ Misses 4846 4751 -95
+ Partials 257 254 -3 🚀 New features to boost your workflow:
|
…n; '_analyse' is now run in the while loop from '_analyse_in_thread'; grouped SPA/tomo-specific Analyser attributes in a separate block
…a-parsing logic block
…ssing is done within the relevant Context blocks
…ell as for contextless files
…tadata from the TomographyContext
* Disentangled the processing logic for the 4 SPA- and Tomography-related contexts * Replaced matching Contexts using 'str(self._context)' with 'self._context.name' * Replaced giant if-else blocks with match-case logic * Use explicit returns
tieneupin
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analyse function previously consisted of a large block of if-else clauses nested in a while loop, making testing the function challenging. Additionally, we found that files that do not pass the
_find_extensionfunction cannot be used to determine the context as part of the current logical workflow in_analyse.This PR aims to resolve these issues by:
_analysefunction into a separate function out of thewhileloop to facilitate easier testing_analysesuch that the file that is used to determine the extension and/or context will also be considered forpost_transfer