Skip to content

Raise an exception if no 2D murfey ids present#683

Merged
stephen-riggs merged 2 commits intomainfrom
raise-no-2d-ids
Oct 17, 2025
Merged

Raise an exception if no 2D murfey ids present#683
stephen-riggs merged 2 commits intomainfrom
raise-no-2d-ids

Conversation

@stephen-riggs
Copy link
Contributor

We keep hitting a case where no ids get sent to 2D classification. It's not clear why this happens, but if we don't have ids to send it would be better to just raise an exception in murfey.

Also I've changed the fixed number of 50 ids to the value in the default parameters (which is also 50 currently).

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.03%. Comparing base (e4b297a) to head (2e79985).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   35.04%   35.03%   -0.02%     
==========================================
  Files          91       91              
  Lines       11122    11126       +4     
  Branches     1479     1481       +2     
==========================================
  Hits         3898     3898              
- Misses       7097     7101       +4     
  Partials      127      127              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one comment about pre-emptively applying the same logic to the 3D class version of this function as well.

@stephen-riggs stephen-riggs merged commit f3e1b83 into main Oct 17, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the raise-no-2d-ids branch October 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants