Raise an exception if no 2D murfey ids present#683
Merged
stephen-riggs merged 2 commits intomainfrom Oct 17, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 35.04% 35.03% -0.02%
==========================================
Files 91 91
Lines 11122 11126 +4
Branches 1479 1481 +2
==========================================
Hits 3898 3898
- Misses 7097 7101 +4
Partials 127 127 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Oct 16, 2025
tieneupin
approved these changes
Oct 16, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Looks good to me! Just one comment about pre-emptively applying the same logic to the 3D class version of this function as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep hitting a case where no ids get sent to 2D classification. It's not clear why this happens, but if we don't have ids to send it would be better to just raise an exception in murfey.
Also I've changed the fixed number of 50 ids to the value in the default parameters (which is also 50 currently).