Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 35.26% 35.77% +0.50%
==========================================
Files 91 92 +1
Lines 11225 11308 +83
Branches 1487 1495 +8
==========================================
+ Hits 3959 4045 +86
+ Misses 7138 7130 -8
- Partials 128 133 +5 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Oct 28, 2025
tieneupin
approved these changes
Oct 28, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Looks good to me. Doesn't seem to be anything obviously wrong. Feel free to merge once you're happy with it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to receive messages back from tomogram picking and then send on a request to run tomogram 2d extraction/classification.
SPAFeedbackParametersto a more generalClassificationFeedbackParametersfor reuseCurrently then set to run 2D classification in batches of 10000 particles with 5 classes. Needs deciding if that is the right value.
Also probably isn't sending exactly the right set of parameters onwards to the next recipe as the recipe hasn't yet been written, but the right items should be stored in the database here.