Skip to content

Fix route manifest CLI output#678

Merged
tieneupin merged 10 commits intomainfrom
fix-route-manifest-cli-output
Oct 13, 2025
Merged

Fix route manifest CLI output#678
tieneupin merged 10 commits intomainfrom
fix-route-manifest-cli-output

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Oct 10, 2025

The initial version of the generate_route_manifest CLI worked, but constructed a YAML file that did not conform to Prettier's formatting standards. After some digging, we found a way to override the built-int Dumper class with one that had indenting and string formatting behaviour that conforms exactly to Prettier's default format.

Additionally, now that we have dropped Python 3.9 (see PR #668), we have updated the type hinting used in the API endpoint functions to use the pipe union notation (e.g, str | int) instead, which makes type checking of incoming path parameters in the url_path_for() function easier to implement.

Finally, we added unit tests for the functions in murfey.util.api and the generate_route_manifest CLI.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 66.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.37%. Comparing base (c6c286e) to head (f5aae34).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   34.40%   34.37%   -0.04%     
==========================================
  Files          92       92              
  Lines       11158    11625     +467     
  Branches     1474     1609     +135     
==========================================
+ Hits         3839     3996     +157     
- Misses       7195     7495     +300     
- Partials      124      134      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review October 13, 2025 10:10
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tieneupin tieneupin merged commit 4f78a6f into main Oct 13, 2025
17 checks passed
@tieneupin tieneupin deleted the fix-route-manifest-cli-output branch October 13, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants