Merged
Conversation
… now that Python 3.9 has been dropped
…ttier's standards
…added logic to format strings according to Prettier's standards as well
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 34.40% 34.37% -0.04%
==========================================
Files 92 92
Lines 11158 11625 +467
Branches 1474 1609 +135
==========================================
+ Hits 3839 3996 +157
- Misses 7195 7495 +300
- Partials 124 134 +10 🚀 New features to boost your workflow:
|
…rs when FastAPI router modules are modified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial version of the
generate_route_manifestCLI worked, but constructed a YAML file that did not conform to Prettier's formatting standards. After some digging, we found a way to override the built-intDumperclass with one that had indenting and string formatting behaviour that conforms exactly to Prettier's default format.Additionally, now that we have dropped Python 3.9 (see PR #668), we have updated the type hinting used in the API endpoint functions to use the pipe union notation (e.g,
str | int) instead, which makes type checking of incoming path parameters in theurl_path_for()function easier to implement.Finally, we added unit tests for the functions in
murfey.util.apiand thegenerate_route_manifestCLI.