Skip to content

Preserve trailing underscores#676

Merged
tieneupin merged 3 commits intomainfrom
preserve-trailing-underscores
Oct 10, 2025
Merged

Preserve trailing underscores#676
tieneupin merged 3 commits intomainfrom
preserve-trailing-underscores

Conversation

@tieneupin
Copy link
Contributor

Encountered an edge case today whereby our use of werkzeug.utils.secure_filename() removed trailing underscores from file path parts, which we should guard against.

This PR streamlines the logic of murfey.utils.__init__.secure_path() and adds safeguards against removing trailing underscores in a file path part. Unit tests were also added to ensure file renaming occurs as expected.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.40%. Comparing base (24d6628) to head (738c187).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   34.32%   34.40%   +0.07%     
==========================================
  Files          92       92              
  Lines       11157    11158       +1     
  Branches     1474     1474              
==========================================
+ Hits         3830     3839       +9     
+ Misses       7202     7195       -7     
+ Partials      125      124       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit c6c286e into main Oct 10, 2025
17 checks passed
@tieneupin tieneupin deleted the preserve-trailing-underscores branch October 10, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants