Merged
Conversation
…ling underscores in file path parts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 34.32% 34.40% +0.07%
==========================================
Files 92 92
Lines 11157 11158 +1
Branches 1474 1474
==========================================
+ Hits 3830 3839 +9
+ Misses 7202 7195 -7
+ Partials 125 124 -1 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered an edge case today whereby our use of
werkzeug.utils.secure_filename()removed trailing underscores from file path parts, which we should guard against.This PR streamlines the logic of
murfey.utils.__init__.secure_path()and adds safeguards against removing trailing underscores in a file path part. Unit tests were also added to ensure file renaming occurs as expected.