Reset tilt series lengths on repeated tilts, to avoid repeat processing#674
Merged
stephen-riggs merged 1 commit intomainfrom Oct 8, 2025
Merged
Reset tilt series lengths on repeated tilts, to avoid repeat processing#674stephen-riggs merged 1 commit intomainfrom
stephen-riggs merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 34.33% 34.32% -0.01%
==========================================
Files 92 92
Lines 11155 11157 +2
Branches 1474 1474
==========================================
Hits 3830 3830
- Misses 7200 7202 +2
Partials 125 125 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Oct 7, 2025
| ).all() | ||
| for ts in tilt_series_db: | ||
| ts.processing_requested = False | ||
| ts.tilt_series_length = -1 |
Contributor
There was a problem hiding this comment.
You'll need to remind me what -1 is used to indicate in the tilt series database table.
Contributor
Author
There was a problem hiding this comment.
-1 just means we don't know the value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tilt series is cancelled on the microscope, an mdoc gets written and we mark the tilt series as complete.
The current behaviour is then that we process the tomogram and do so again for every newly found tilt.
This PR changes the code to remove knowledge of tilt series length when a new tilt is found (i.e. when length exceeds the number in the mdoc). This then means we will not launch processing again until the mdoc is re-written with the correct length.
Should reduce the number of processing times from ntilts+1 to 2.
Will still need some work on the processing side as the processed star files contain duplicated tomograms.