More checks for skipped files on visit end time#672
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 34.37% 34.34% -0.03%
==========================================
Files 92 92
Lines 11143 11151 +8
Branches 1472 1473 +1
==========================================
Hits 3830 3830
- Misses 7188 7196 +8
Partials 125 125 🚀 New features to boost your workflow:
|
tieneupin
approved these changes
Sep 30, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Looks good. The visit complete cleanup successfully wipes the directory without touching known skipped files, and the log showing the status of rsyncers, analysers, and watchers works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At visit end, do not check the end time of the files. Instead, if they were not skipped before they should be transferred. If skipped before, ignore them.
Also adds log to determine which bit of the dormancy check is failing.