Allow database override for reinjecting failed API calls#660
Merged
stephen-riggs merged 6 commits intomainfrom Sep 16, 2025
Merged
Allow database override for reinjecting failed API calls#660stephen-riggs merged 6 commits intomainfrom
stephen-riggs merged 6 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
+ Coverage 33.93% 33.94% +0.01%
==========================================
Files 92 92
Lines 11178 11180 +2
Branches 1472 1472
==========================================
+ Hits 3793 3795 +2
Misses 7256 7256
Partials 129 129 🚀 New features to boost your workflow:
|
8abb29c to
3b7ce70
Compare
d-j-hatton
approved these changes
Sep 16, 2025
Contributor
|
yeah, we'll need to rationalise naming at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The database is set to default to the one in the security configuration in parts of the feedback process.
To make it easier to use the API call reinjection these should take the database as input instead, and only the overall
feedback_callbackfunction should have the default.A similar problem occurs with the machine configuration which will need to be set when using the API reinjection for now.
One naming issue is we import the database spec as
dbinto feedback.py then have_dbas a session object. This might be confusing.