Skip to content

Allow database override for reinjecting failed API calls#660

Merged
stephen-riggs merged 6 commits intomainfrom
repost-control-db
Sep 16, 2025
Merged

Allow database override for reinjecting failed API calls#660
stephen-riggs merged 6 commits intomainfrom
repost-control-db

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Sep 9, 2025

The database is set to default to the one in the security configuration in parts of the feedback process.
To make it easier to use the API call reinjection these should take the database as input instead, and only the overall feedback_callback function should have the default.

A similar problem occurs with the machine configuration which will need to be set when using the API reinjection for now.

One naming issue is we import the database spec as db into feedback.py then have _db as a session object. This might be confusing.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 26.04167% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.94%. Comparing base (61d17f0) to head (4bbeaed).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   33.93%   33.94%   +0.01%     
==========================================
  Files          92       92              
  Lines       11178    11180       +2     
  Branches     1472     1472              
==========================================
+ Hits         3793     3795       +2     
  Misses       7256     7256              
  Partials      129      129              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-j-hatton
Copy link
Contributor

yeah, we'll need to rationalise naming at some point

@stephen-riggs stephen-riggs merged commit 38c47db into main Sep 16, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the repost-control-db branch September 16, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants