Skip to content

Record skipped files in prometheus#642

Merged
tieneupin merged 10 commits intomainfrom
prom-skip-files
Jul 28, 2025
Merged

Record skipped files in prometheus#642
tieneupin merged 10 commits intomainfrom
prom-skip-files

Conversation

@stephen-riggs
Copy link
Contributor

Will allow us to be notified when files are skipped due to visit end times

@stephen-riggs stephen-riggs requested a review from tieneupin July 22, 2025 11:07
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.56%. Comparing base (41e0dfa) to head (a4c3c46).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
+ Coverage   33.52%   33.56%   +0.03%     
==========================================
  Files          92       92              
  Lines       11245    11254       +9     
  Branches     1474     1474              
==========================================
+ Hits         3770     3777       +7     
- Misses       7348     7350       +2     
  Partials      127      127              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR works. It not working in the dev setup is a fault of mine when configuring the routing logic that I've now addressed.

I've optimised the logic so that the skipped files are tracked on a per rsyncer basis, and have also added logic to reset the counter when a flush is successfully triggered.

@tieneupin tieneupin merged commit d68a67a into main Jul 28, 2025
17 checks passed
@tieneupin tieneupin deleted the prom-skip-files branch July 28, 2025 13:24
@stephen-riggs
Copy link
Contributor Author

Thanks for looking, and for adding the logic to set the skipped files values to zero when started and flushed.

I had intentionally not included the rsyncer in the tracking, as I think we only care about skipped files on a session level, but no harm in adding the rsyncer anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants