Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 33.52% 33.56% +0.03%
==========================================
Files 92 92
Lines 11245 11254 +9
Branches 1474 1474
==========================================
+ Hits 3770 3777 +7
- Misses 7348 7350 +2
Partials 127 127 🚀 New features to boost your workflow:
|
…s triggered for that RSyncer
…nd to group skipped file information by source
…on is also included
…registering an Rsyncer, and removed redundant lines
…cleaning up a session
tieneupin
left a comment
There was a problem hiding this comment.
Your PR works. It not working in the dev setup is a fault of mine when configuring the routing logic that I've now addressed.
I've optimised the logic so that the skipped files are tracked on a per rsyncer basis, and have also added logic to reset the counter when a flush is successfully triggered.
|
Thanks for looking, and for adding the logic to set the skipped files values to zero when started and flushed. I had intentionally not included the rsyncer in the tracking, as I think we only care about skipped files on a session level, but no harm in adding the rsyncer anyway. |
Will allow us to be notified when files are skipped due to visit end times