Conversation
…of dormant controllers and split the dormant controller parsing and deletion into separate for loops
…d is safe to stop
…iated threads * Removed the dormancy check callback from the Analyser and DirWatcher when they are started up by the MultigridController * The dormancy check is now done by the MultigridController as part of a while loop once it is ordered to finalise things
* Instrument server logs to console at the INFO level * Instrument server logs Murfey-related events to Graylog at the DEBUG level, but logs at the INFO level for other packages
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 33.29% 33.24% -0.06%
==========================================
Files 90 90
Lines 11132 11185 +53
Branches 1463 1470 +7
==========================================
+ Hits 3706 3718 +12
- Misses 7299 7339 +40
- Partials 127 128 +1 🚀 New features to boost your workflow:
|
…d the post-session cleanup process
… return a dictionary with useful properties regarding the status of the multigrid controller
…ly to be useful for now; ignore RuntimeError when trying to start a MultigridWatcher, as this can trigger when the backend server is rebooted and the client is running
…for the current session is not found
…oller, which can be used to target which queries to refetch on the frontend side
d-j-hatton
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt at fixing the session clean-up logic worked partially, but the threads associated with the session did not close properly as they ended up monitoring themselves and each other to see if they are closed.
This PR fixes that by having the multigrid controller thread be responsible for the creation and collection of the clean-up threads on the client side, before then submitting the request to clear the database of that particular session, and finally submitting a web socket message to notify the frontend (if present) of the change in state.
Additionally, this PR also adds more keys to the web socket messages sent by the client side, which can be used by the frontend to reload data from the backend as needed. It also adds conditionals to the endpoint functions that get information about the processes running on the client such that they error quietly if a component associated with that session ID doesn't exist on the client side. Furthermore, it also adjusts the logging setup for the client instrument server such that debug logs are sent to the logging dashboard, but won't be displayed on the console.