Apply shifts needed for atlas displays on Talos and Falcon-Krios#639
Merged
stephen-riggs merged 2 commits intomainfrom Jul 18, 2025
Merged
Apply shifts needed for atlas displays on Talos and Falcon-Krios#639stephen-riggs merged 2 commits intomainfrom
stephen-riggs merged 2 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
=======================================
Coverage 32.98% 32.98%
=======================================
Files 90 90
Lines 11151 11153 +2
Branches 1470 1471 +1
=======================================
+ Hits 3678 3679 +1
- Misses 7340 7347 +7
+ Partials 133 127 -6 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jul 18, 2025
tieneupin
approved these changes
Jul 18, 2025
Contributor
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Looks good, but short comments describing the transformations these matrices correspond to would be appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these are the necessary changes for search map locations on atlases.
Something similar will probably be needed for tomogram locations on search maps