Added endpoints to check status of multigrid controllers#636
Merged
Added endpoints to check status of multigrid controllers#636
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 32.92% 33.00% +0.07%
==========================================
Files 90 90
Lines 11127 11145 +18
Branches 1468 1470 +2
==========================================
+ Hits 3664 3678 +14
- Misses 7332 7334 +2
- Partials 131 133 +2 🚀 New features to boost your workflow:
|
…ultigrid controller for a given session id
…ultiple 'mock.patch' decorators
…nt, now that we know how to do so
stephen-riggs
approved these changes
Jul 17, 2025
Contributor
stephen-riggs
left a comment
There was a problem hiding this comment.
All looks fine to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new FastAPI endpoints to the backend and instrument servers to query the existence of a multigrid controller for a given session. Needed as part of redirection logic on the frontend when users visit an incompletely set up session (see PR #40).
Currently, the dictionary returned is
{"exists": True}, but if you have suggestions for what could be a more appropriate key, do share.Also started new test modules for the backend instrument server module and updated the tests on the client-side instrument server with more optimised tests.