Skip to content

Added endpoints to check status of multigrid controllers#636

Merged
tieneupin merged 14 commits intomainfrom
add-controller-checking-endpoints
Jul 17, 2025
Merged

Added endpoints to check status of multigrid controllers#636
tieneupin merged 14 commits intomainfrom
add-controller-checking-endpoints

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jul 17, 2025

Adds new FastAPI endpoints to the backend and instrument servers to query the existence of a multigrid controller for a given session. Needed as part of redirection logic on the frontend when users visit an incompletely set up session (see PR #40).

Currently, the dictionary returned is {"exists": True}, but if you have suggestions for what could be a more appropriate key, do share.

Also started new test modules for the backend instrument server module and updated the tests on the client-side instrument server with more optimised tests.

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 51.51515% with 16 lines in your changes missing coverage. Please review.

Project coverage is 33.00%. Comparing base (64894b1) to head (fe10c62).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   32.92%   33.00%   +0.07%     
==========================================
  Files          90       90              
  Lines       11127    11145      +18     
  Branches     1468     1470       +2     
==========================================
+ Hits         3664     3678      +14     
- Misses       7332     7334       +2     
- Partials      131      133       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review July 17, 2025 13:07
@tieneupin tieneupin requested a review from d-j-hatton July 17, 2025 13:07
@tieneupin tieneupin self-assigned this Jul 17, 2025
@tieneupin tieneupin requested a review from stephen-riggs July 17, 2025 13:07
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component client Relates to the client component labels Jul 17, 2025
@tieneupin tieneupin changed the title Add endpoints to check status of multigrid controllers Added endpoints to check status of multigrid controllers Jul 17, 2025
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me

@tieneupin tieneupin merged commit 4dfe02e into main Jul 17, 2025
17 checks passed
@tieneupin tieneupin deleted the add-controller-checking-endpoints branch July 17, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component enhancement New feature or request server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants