Skip to content

Scale search map dimensions and location to be those on jpg#635

Merged
stephen-riggs merged 5 commits intomainfrom
scale-tomo-atlas
Jul 17, 2025
Merged

Scale search map dimensions and location to be those on jpg#635
stephen-riggs merged 5 commits intomainfrom
scale-tomo-atlas

Conversation

@stephen-riggs
Copy link
Contributor

@stephen-riggs stephen-riggs commented Jul 16, 2025

The size and location of the search maps we insert into ispyb are currently those on the atlas mrc. This scales them to be those on the jpg, and also scales the location of tomograms on search maps.

Also inserts an angle of 0 and handles inserting atlas pixel size when a data collection group is first made.

Something similar will probably be needed for the tomogram sizes on search maps, but that may need to be done in pato as there is an extra scaling based on pixel sizes as well.

@stephen-riggs stephen-riggs requested a review from d-j-hatton July 16, 2025 11:14
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.91%. Comparing base (64894b1) to head (9c18014).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   32.92%   32.91%   -0.02%     
==========================================
  Files          90       90              
  Lines       11127    11133       +6     
  Branches     1468     1468              
==========================================
  Hits         3664     3664              
- Misses       7332     7338       +6     
  Partials      131      131              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stephen-riggs stephen-riggs merged commit 7ea973e into main Jul 17, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the scale-tomo-atlas branch July 17, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants