Scale search map dimensions and location to be those on jpg#635
Merged
stephen-riggs merged 5 commits intomainfrom Jul 17, 2025
Merged
Scale search map dimensions and location to be those on jpg#635stephen-riggs merged 5 commits intomainfrom
stephen-riggs merged 5 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 32.92% 32.91% -0.02%
==========================================
Files 90 90
Lines 11127 11133 +6
Branches 1468 1468
==========================================
Hits 3664 3664
- Misses 7332 7338 +6
Partials 131 131 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size and location of the search maps we insert into ispyb are currently those on the atlas mrc. This scales them to be those on the jpg, and also scales the location of tomograms on search maps.
Also inserts an angle of 0 and handles inserting atlas pixel size when a data collection group is first made.
Something similar will probably be needed for the tomogram sizes on search maps, but that may need to be done in pato as there is an extra scaling based on pixel sizes as well.