Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jul 7, 2025

  • Removed 'label' field from the 'RsyncerSource' Pydantic models as it is no longer needed
  • Removed the key from requests to endpoints that use that model
  • Omit the 'no rsync process ran for files' error message if files weren't scheduled for transfer to begin with
  • Update the database with a new timestamp if it's later than the currently stored one when a flush is triggered
  • The Rsyncer end time updates are now set by the instrument server, and not as part of the flush
  • Store the time difference between the client and the server as an attribute in the MultigridController and convert incoming visit end time updates to client-side time

…emoved the key from requests to endpoints that use that model
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (4d783a7) to head (e1a9cf7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   31.86%   31.81%   -0.06%     
==========================================
  Files          90       90              
  Lines       10762    10776      +14     
  Branches     1422     1426       +4     
==========================================
- Hits         3429     3428       -1     
- Misses       7215     7230      +15     
  Partials      118      118              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s were scheduled for transfer; this should skip the case of an empty list
@tieneupin tieneupin marked this pull request as ready for review July 7, 2025 14:25
@tieneupin tieneupin self-assigned this Jul 7, 2025
@tieneupin tieneupin added bug Something isn't working server Relates to the server component client Relates to the client component labels Jul 7, 2025
@tieneupin tieneupin marked this pull request as draft July 7, 2025 14:46
tieneupin added 4 commits July 7, 2025 17:43
…ring a flush, but only if the end time is greater than what is currently stored in the database
… server endpoint, and not as part of the flush
…ute in the MultigridController; convert the received server timestamp into the client's time when updating visit end times
…ltigrid_controller_visit_end_time' endpoints in the instrument server
@tieneupin tieneupin marked this pull request as ready for review July 7, 2025 17:44
@stephen-riggs stephen-riggs merged commit 2602b0a into main Jul 8, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the fix-flush-skipped-files branch July 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working client Relates to the client component server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants