Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

This addresses two problems which came up:

  1. If find extension fails we should skip the file, and not try and process with the wrong extension. Fixes Database file was treated as a fractions file #605
  2. Tomography multigrid currently would trigger with the wrong parameters. Fixes Tomography after SPA processes with the wrong parameters #606

To resolve the multigrid problems I have moved the parameters from the environment to the context.
This also removes some of the client-side parameters which aren't needed such as boxsizes.

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 20.25316% with 63 lines in your changes missing coverage. Please review.

Project coverage is 31.82%. Comparing base (041056e) to head (c3e628d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   31.85%   31.82%   -0.03%     
==========================================
  Files          91       90       -1     
  Lines       10747    10697      -50     
  Branches     1429     1417      -12     
==========================================
- Hits         3423     3404      -19     
+ Misses       7211     7178      -33     
- Partials      113      115       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -421,11 +421,16 @@ def _start_dc(self, json, from_form: bool = False):
json = json.get("form", {})
Copy link
Contributor

@tieneupin tieneupin Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance json could be replaced with something more indicative of its contents, since it seems to be passed around quite a bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done this. Might need to check that I haven't broken anything by missing references to it

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about variable names, but other than that, no obvious issues. The test runs also seem to work as intended.

@tieneupin tieneupin merged commit 25e0074 into main Jun 12, 2025
17 checks passed
@tieneupin tieneupin deleted the context-dc-params branch June 12, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tomography after SPA processes with the wrong parameters Database file was treated as a fractions file

2 participants