-
Notifications
You must be signed in to change notification settings - Fork 1
Assign parameters per context rather than per environment #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 31.85% 31.82% -0.03%
==========================================
Files 91 90 -1
Lines 10747 10697 -50
Branches 1429 1417 -12
==========================================
- Hits 3423 3404 -19
+ Misses 7211 7178 -33
- Partials 113 115 +2 🚀 New features to boost your workflow:
|
| @@ -421,11 +421,16 @@ def _start_dc(self, json, from_form: bool = False): | |||
| json = json.get("form", {}) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance json could be replaced with something more indicative of its contents, since it seems to be passed around quite a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done this. Might need to check that I haven't broken anything by missing references to it
tieneupin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about variable names, but other than that, no obvious issues. The test runs also seem to work as intended.
This addresses two problems which came up:
To resolve the multigrid problems I have moved the parameters from the environment to the context.
This also removes some of the client-side parameters which aren't needed such as boxsizes.