Skip to content

Remove the assumption of a raw directory for processed outputs #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

stephen-riggs
Copy link
Contributor

Resolves one of the doppio-live issues, where we assume a raw directory for SPA.

This instead makes it a configurable option, where the raw is added to the path if process_multiple_datasets is True, so that in cases such as eBIC where we send multiple datasets to one location they are still divided up.

Also makes the path construction consistent between SPA and tomo, which will need checking.

@stephen-riggs stephen-riggs requested a review from d-j-hatton May 30, 2025 12:47
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 31.86%. Comparing base (2d3e030) to head (f491f06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   31.77%   31.86%   +0.08%     
==========================================
  Files          90       90              
  Lines       10700    10686      -14     
  Branches     1422     1419       -3     
==========================================
+ Hits         3400     3405       +5     
+ Misses       7187     7168      -19     
  Partials      113      113              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the SPA and tomo workflows seem to work fine with the key activated and deactivated. Looks good.

@stephen-riggs stephen-riggs merged commit c5a5767 into main Jun 2, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the no-raw branch June 2, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants