Skip to content

Handle ISPyB errors safely#593

Merged
tieneupin merged 1 commit intomainfrom
handle-ispyb-load-errors
May 20, 2025
Merged

Handle ISPyB errors safely#593
tieneupin merged 1 commit intomainfrom
handle-ispyb-load-errors

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented May 19, 2025

This is part of ongoing work to eventually allow Murfey to run as a demo for testing purposes without its other components.
Attempts to load Murfey as much as is possible even if the ISPyB connection fails or a credentials file is not specified.

@tieneupin tieneupin requested a review from stephen-riggs May 19, 2025 11:42
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (59297f9) to head (2d2bc47).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   30.19%   30.19%   -0.01%     
==========================================
  Files          80       80              
  Lines       10567    10569       +2     
  Branches     1410     1409       -1     
==========================================
  Hits         3191     3191              
- Misses       7270     7272       +2     
  Partials      106      106              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin requested a review from d-j-hatton May 19, 2025 11:43
@tieneupin tieneupin merged commit f0ff051 into main May 20, 2025
17 checks passed
@tieneupin tieneupin deleted the handle-ispyb-load-errors branch May 20, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants