Skip to content

Update when starting Instrument Server, and deprecate client#586

Merged
tieneupin merged 2 commits intomainfrom
update-on-IS-start
May 8, 2025
Merged

Update when starting Instrument Server, and deprecate client#586
tieneupin merged 2 commits intomainfrom
update-on-IS-start

Conversation

@stephen-riggs
Copy link
Contributor

This copies in the update code into the instrument server startup, so the client doesn't have to be started for updates.

Also here's a suggestion of how to deprecate (but not remove) the client. Not sure whether we want to do that though as it may cause more issues than it solves.

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.17%. Comparing base (368dd2f) to head (5aa9d2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   30.17%   30.17%   -0.01%     
==========================================
  Files          80       80              
  Lines       10509    10516       +7     
  Branches     1405     1405              
==========================================
+ Hits         3171     3173       +2     
- Misses       7233     7238       +5     
  Partials      105      105              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work, from the testing I've done so far. Thanks for sorting this out!

@tieneupin tieneupin merged commit 88a6f93 into main May 8, 2025
17 checks passed
@tieneupin tieneupin deleted the update-on-IS-start branch May 8, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants