Skip to content

Modified API endpoint that RsyncInstance deletion requests are sent to#578

Merged
tieneupin merged 1 commit intomainfrom
fix-delete-rsyncer
Apr 15, 2025
Merged

Modified API endpoint that RsyncInstance deletion requests are sent to#578
tieneupin merged 1 commit intomainfrom
fix-delete-rsyncer

Conversation

@tieneupin
Copy link
Contributor

Passing paths in the URL to a FastAPI endpoint will cause leading '/' in Unix-style paths to be removed. Passing the path as a properly quoted/escaped query component in the URL will prevent this from occurring.

Also added a log to capture information about what source and session ID the request fails on.

… to; added log to capture when a deletion request fails on a specified RsyncerInstance
@tieneupin tieneupin requested a review from d-j-hatton April 15, 2025 13:09
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.22%. Comparing base (b88806d) to head (e368880).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   30.23%   30.22%   -0.01%     
==========================================
  Files          80       80              
  Lines       10499    10502       +3     
  Branches     1401     1401              
==========================================
  Hits         3174     3174              
- Misses       7220     7223       +3     
  Partials      105      105              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit e1fa429 into main Apr 15, 2025
17 checks passed
@tieneupin tieneupin deleted the fix-delete-rsyncer branch April 15, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants