Remove the manual tilt offset from the user parameters, and the table which contains it#572
Merged
stephen-riggs merged 5 commits intomainfrom Apr 16, 2025
Merged
Remove the manual tilt offset from the user parameters, and the table which contains it#572stephen-riggs merged 5 commits intomainfrom
stephen-riggs merged 5 commits intomainfrom
Conversation
Contributor
|
Will test this after testing PR #567 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 30.21% 30.19% -0.03%
==========================================
Files 80 80
Lines 10510 10468 -42
Branches 1401 1397 -4
==========================================
- Hits 3176 3161 -15
+ Misses 7229 7202 -27
Partials 105 105 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Apr 15, 2025
tieneupin
approved these changes
Apr 15, 2025
Contributor
There was a problem hiding this comment.
Other than one comment recommending that the function name should match the table it is interacting with, it all looks good and runs smoothly on both the TUI and instrument server. Thanks for doing this!
This will require a database reset, so I will reserve merging until we've all been able to discuss it again in person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a
TomographyProcessingParameterstable in the database which just contained the tilt offset. This removes that table and renames theTomographyPreprocessingParametersto just beTomographyProcessingParameters.I've also removed
manual_tilt_offsetfrom the client side entirely, as it is calculated server-side. I expect that will mean it disappears from the TUI display.The renaming in particular is a high-risk change, which needs a test build and run before we can say this works.