Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

DiamondLightSource / python-murfey Public

Notifications You must be signed in to change notification settings
Fork 1
Star 2

Code
Issues 45
Pull requests 7
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

Further instrument server fixes + improving test coverage#570

Merged

tieneupin merged 27 commits intomainDiamondLightSource/python-murfey:mainfrom

instrument-server-fixesDiamondLightSource/python-murfey:instrument-server-fixesCopy head branch name to clipboard

Apr 10, 2025

Conversation Commits27 (27)Checks Files changed

Merged

Further instrument server fixes + improving test coverage#570
tieneupin merged 27 commits intomainfrom
instrument-server-fixes

Commits

Commits on Apr 9, 2025

Captured post request when registering tomography preprocessing parameters; leave 'None' as-is when preparing the JSON data in '_start_dc'
tieneupin
committed
Fixed logic when parsing MachineConfig for rsync URL
tieneupin
committed
Allow 'None' in 'dose_per_frame' key in 'Base' sub-class
tieneupin
committed
Added unit test for 'upload_gain_reference()' API endpoint
tieneupin
committed
Adjusted location of comments
tieneupin
committed
Fixed which function/module layer to mock
tieneupin
committed
Tried fixing the 'requests.get' mock
tieneupin
committed
Typo in URL path to endpoint to test
tieneupin
committed
Commented out 'mock_request' to see if test function actually runs
tieneupin
committed
Adjusted assertion logic for urlparse result
tieneupin
committed
Adjusted assertion logic for urlparse return value
tieneupin
committed
Check if endpoint is being poked correctly first
tieneupin
committed

Commits on Apr 10, 2025

Try testing the function by itself, and not as a FastAPI call
tieneupin
committed
Forgot remove extra variables after changing length of parameter tuple being passed in
tieneupin
committed
Check contents of request.get() call
tieneupin
committed
Try using unittest.mock.ANY to skip token authentication check
tieneupin
committed
Added fixture to simulate a pre-loaded client-side configuration ConfigParser object
tieneupin
committed
Added test for '_get_murfey_url' function
tieneupin
committed
Parametrised the '_get_murfey_url' test
tieneupin
committed
Code block shouldn't have to be indented
tieneupin
committed
Added 'http://' to URL test cases with no schemes when performing comparison at the end
tieneupin
committed
'tokens' variable should not require mocking anymore
tieneupin
committed
Turns out the token still needs to be mocked, oops
tieneupin
committed
Removed residual comment
tieneupin
committed
Does 'stderr' need to be set if that branch of logic is not tested here?
tieneupin
committed
Test for 'port' and 'hostname' attributes as well
tieneupin
committed
Rearranged code in blocks according to purpose
tieneupin
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.