Skip to content

Conversation

@tieneupin
Copy link
Contributor

The new logs I added for the 'data_collection' block in 'feedback_callback()' didn't sanitise the dictionary values from the message correctly. They need to be stringified first (as they could be non-str) before sanitisation. This PR should fix that.

@tieneupin tieneupin added bug Something isn't working server Relates to the server component labels Apr 8, 2025
@tieneupin tieneupin requested a review from d-j-hatton April 8, 2025 13:50
@tieneupin tieneupin self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.78%. Comparing base (8567d8d) to head (2455e65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   28.78%   28.78%   -0.01%     
==========================================
  Files          80       80              
  Lines       10605    10604       -1     
  Branches     1414     1414              
==========================================
- Hits         3053     3052       -1     
  Misses       7450     7450              
  Partials      102      102              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit a32d16e into main Apr 8, 2025
17 checks passed
@tieneupin tieneupin deleted the feedback-callback-fix branch April 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants