Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 28.85% 28.84% -0.01%
==========================================
Files 80 80
Lines 10564 10567 +3
Branches 1406 1406
==========================================
Hits 3048 3048
- Misses 7414 7417 +3
Partials 102 102 🚀 New features to boost your workflow:
|
d-j-hatton
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client-side websocket component previously took the server URL and passed it through
urllib.parse.urlparse(server)._replace(scheme="ws", path=""). This would have eliminated any trailing URL paths after the netloc component, which would be present if the request was redirected to the backend server through a proxy and had its URL re-mapped (e.g. the URL after redirecting through the web UI could be"http://{hostname}:{port}/proxy_path/path/to/end/point").This PR accounts for that by storing the URL path of the server it is attempting to connect to, and will correctly insert that into the final websocket URL constructed.
This same problem occurs when the TUI client tries to submit a version check and update request to the server, so the same fix was applied to that branch of logic. Interestingly, a trailing slash "/" is now needed when constructing the version check query (i.e.
url._replace(path="{proxy_path}/version/", ... )) in order for the request to be successful. It throws an error otherwise.