Skip to content

Ignore unset notification parameters #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-j-hatton merged 1 commit into from
Mar 19, 2025
Merged

Ignore unset notification parameters #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/murfey/workflows/notifications/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,16 @@
enp.max_value = v[1]
break
else:
new_notification_parameters.append(
NotificationParameter(
dcg_id=dcgid,
name=k,
min_value=v[0],
max_value=v[1],
num_instances_since_triggered=num_instances_between_triggers,
if v[0] is not None and v[1] is not None:
new_notification_parameters.append(

Check warning on line 39 in src/murfey/workflows/notifications/__init__.py

View check run for this annotation

Codecov / codecov/patch

src/murfey/workflows/notifications/__init__.py#L39 

Added line #L39 was not covered by tests
NotificationParameter(
dcg_id=dcgid,
name=k,
min_value=v[0],
max_value=v[1],
num_instances_since_triggered=num_instances_between_triggers,
)
)
)
murfey_db.add_all(existing_notification_parameters + new_notification_parameters)
murfey_db.commit()
murfey_db.close()
Expand Down