Skip to content

Replaced Path().resolve() with Path().absolute() in client-side modules#517

Merged
tieneupin merged 3 commits intomainfrom
fix-path-logic
Mar 20, 2025
Merged

Replaced Path().resolve() with Path().absolute() in client-side modules#517
tieneupin merged 3 commits intomainfrom
fix-path-logic

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Mar 18, 2025

Added some logic to guard against working with Windows Path objects in MSYS2.

  • Remote servers get evaluated to their IP addresses when using Path().resolve(); switched to using Path().absolute()
  • Drive letters (e.g. Path("F:")) cannot be used directly to construct paths (e.g. Path("F:") / "some" / "directory" will evaluate to "F:some/directory", which blatantly doesn't exist; using Path("F:").absolute() / "some" / "directory" fixes this

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.74%. Comparing base (7601cb4) to head (a5e9e35).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   28.92%   29.74%   +0.81%     
==========================================
  Files          79       79              
  Lines       10246    10913     +667     
  Branches     1357     1475     +118     
==========================================
+ Hits         2964     3246     +282     
- Misses       7181     7558     +377     
- Partials      101      109       +8     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin requested a review from stephen-riggs March 20, 2025 12:21
@tieneupin tieneupin self-assigned this Mar 20, 2025
@tieneupin tieneupin added bug Something isn't working client Relates to the client component labels Mar 20, 2025
@tieneupin tieneupin marked this pull request as ready for review March 20, 2025 12:27
@tieneupin tieneupin merged commit d9ad8b6 into main Mar 20, 2025
17 checks passed
@tieneupin tieneupin deleted the fix-path-logic branch March 20, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working client Relates to the client component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants