Read tilt axis from mdoc and send to tomographic alignment #505
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 28.62% 28.64% +0.01%
==========================================
Files 78 78
Lines 10219 10223 +4
Branches 1354 1354
==========================================
+ Hits 2925 2928 +3
- Misses 7194 7195 +1
Partials 100 100 🚀 New features to boost your workflow:
|
| "frame_count": environment.data_collection_parameters.get( | ||
| "frame_count", 0 | ||
| ), | ||
| "tilt_axis": environment.data_collection_parameters.get( |
There was a problem hiding this comment.
What's the rationale behind defaulting to 85 degrees?
There was a problem hiding this comment.
Typically the tilt axis is around that, on our microscopes it seems to be between about 83 and 87 degrees. This value gets sent to AreTomo which takes is as an initial guess to refine from, so it doesn't need to be exact
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Other than a question about the choice of default value for the angle, looks good!
src/murfey/client/contexts/tomo.py
Outdated
| mdoc_metadata["experiment_type"] = "tomography" | ||
| mdoc_metadata["voltage"] = float(mdoc_data["Voltage"]) | ||
| mdoc_metadata["frame_count"] = int(mdoc_data_block["NumSubFrames"]) | ||
| mdoc_metadata["tilt_axis"] = float(mdoc_data["RotationAngle"]) |
There was a problem hiding this comment.
"RotationAngle" is found in mdoc_data_block, not mdoc_data
|
With that |
2 participants
The tilt axis is present in the mdoc files. While it isn't required for tomogram alignment, AreTomo seems less prone to predicting wrong axes when one is provided