Various fixes to CLEM workflow and bootstrap API endpoints#494
Various fixes to CLEM workflow and bootstrap API endpoints#494
Conversation
… of machine config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
+ Coverage 27.93% 28.61% +0.67%
==========================================
Files 78 78
Lines 10255 10218 -37
Branches 1355 1354 -1
==========================================
+ Hits 2865 2924 +59
+ Misses 7295 7194 -101
- Partials 95 100 +5 |
…void race conditions when transferring/registering items
stephen-riggs
left a comment
There was a problem hiding this comment.
Mostly looks fine. I'm a little unsure on the bits avoiding race conditions though. It would be nicer if you didn't have to do the waits, so is there a way to avoid doing the checks and refreshes?
I've noted the places you do the waits. If they're unavoidable then just dismiss the comments, but it feels like some of the checks aren't needed.
Your suggestion worked! I disabled all the Your suggestion to remove the |
stephen-riggs
left a comment
There was a problem hiding this comment.
Thanks for making the changes, it looks much cleaner without the refreshes and sleeps. Looks good to me now :)
One thing led to another, and now there are a couple of fixes present in this PR:
Checks: