Update the dlq reposting tool to not require zocalo #493
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 27.29% 28.07% +0.78%
==========================================
Files 78 78
Lines 10212 10494 +282
Branches 1362 1467 +105
==========================================
+ Hits 2787 2946 +159
- Misses 7330 7434 +104
- Partials 95 114 +19 |
| dlqmsg["message"], | ||
| headers=clean_header, | ||
| ) | ||
| dlqfile.unlink() |
There was a problem hiding this comment.
If I'm understanding the function correctly, you're deleting the DLQ message after resubmission. Is it worth implementing flags such as in the cryoemservices implementation of this function to control whether to keep or delete DLQ messages upon resubmission?
There was a problem hiding this comment.
The main reason we need the tool in murfey is to handle failed API posts.
I've deliberately kept the tool simple, and with limited functionality for safety.
So it will only repost what it purges, and cannot be used to save or modify messages, or post other things to the API.
We could implement more flags, but it would just be duplicating functionality that can be got through the cryoemservices tool.
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Some suggestions, but looks good otherwise!
2 participants
Modifies the tool to repost failed client posts to the murfey api, by removing the need for zocalo.
Also no longer needs the token to be provided, it takes the security configuration file as an argument and works out the token from that.
Uses some code copied across from
cryoem-services, which originates frompython-zocalo