Conversation
There are some hard coded parameters in here at the moment
The email body is a little sparse at the moment but we're trying to avoid recording too much information in the database
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 28.65% 28.94% +0.28%
==========================================
Files 78 79 +1
Lines 10238 10238
Branches 1357 1355 -2
==========================================
+ Hits 2934 2963 +29
+ Misses 7203 7171 -32
- Partials 101 104 +3 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Mar 12, 2025
tieneupin
reviewed
Mar 12, 2025
…urce/python-murfey into email-notification-hookup
…aram in NotificationValue table
…d logs to notify when notification is sent
…ed; optimised logic for subsequent emails
stephen-riggs
approved these changes
Mar 13, 2025
stephen-riggs
pushed a commit
to DiamondLightSource/cryoem-services
that referenced
this pull request
Mar 13, 2025
…age sent back from cryolo (#136) The PR at DiamondLightSource/python-murfey#484 looks for parameters named particle_count, astigmatism, defocus, and resolution in the messages received by the feedback queue, and these values appear to be calculated as part of the CTFFind service, but are not passed on back to Murfey. This PR adds those values to the message sent by the Cryolo service back to Murfey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put in the functionality to setup notification triggering for a data collection group on the receipt of a message from PATo. The conditions for requesting an email notification are the following: