Skip to content

Data collection group registration hooks #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-j-hatton merged 2 commits into from
Feb 11, 2025
Merged

Data collection group registration hooks #483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
767d998
Sort out mess
d-j-hatton Feb 10, 2025
b9fd2c5
Will need the session ID here
d-j-hatton Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/murfey/server/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2557,6 +2557,16 @@
message.get("tag"): dcgid
}
_transport_object.transport.ack(header)
if dcg_hooks := entry_points().select(
group="murfey.hooks", name="data_collection_group"
):
try:

Check warning on line 2563 in src/murfey/server/__init__.py

View check run for this annotation

Codecov / codecov/patch

src/murfey/server/__init__.py#L2563 

Added line #L2563 was not covered by tests
for hook in dcg_hooks:
hook(dcgid, session_id=message["session_id"])
except Exception:
logger.error(

Check warning on line 2567 in src/murfey/server/__init__.py

View check run for this annotation

Codecov / codecov/patch

src/murfey/server/__init__.py#L2565-L2567 

Added lines #L2565 - L2567 were not covered by tests
"Call to data collection group hook failed", exc_info=True
)
return None
elif message["register"] == "atlas_update":
if _transport_object:
Expand Down