Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jan 30, 2025

The client-side TUI was requesting for the machine config using a server API endpoint that relied on the server having a pre-defined BEAMLINE environment variable, which is something we're moving away from. This PR replaces those endpoint requests with the one that loads the machine config that matches the client's instrument name.

Also fixes minor broken logic prevent the visit creation screen from working, and adds a log to report on the rsync remote path being used.

Verification checks:

  • Simulated CLEM session ran successfully through to completion, with processing being triggered correctly.

@tieneupin tieneupin added server Relates to the server component client Relates to the client component labels Jan 30, 2025
@tieneupin tieneupin requested a review from d-j-hatton January 30, 2025 11:17
@tieneupin tieneupin self-assigned this Jan 30, 2025
@tieneupin tieneupin marked this pull request as draft January 30, 2025 11:19
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.40%. Comparing base (32f8ef7) to head (84b8742).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   27.39%   27.40%   +0.01%     
==========================================
  Files          78       78              
  Lines       10138    10140       +2     
  Branches     1333     1332       -1     
==========================================
+ Hits         2777     2779       +2     
  Misses       7266     7266              
  Partials       95       95              

@tieneupin tieneupin merged commit 154f97f into main Jan 31, 2025
17 checks passed
@tieneupin tieneupin deleted the tui-fixes branch January 31, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants