Ensure foil hole id is in the database before inserting movie#470
Merged
stephen-riggs merged 3 commits intomainfrom Jan 28, 2025
Merged
Ensure foil hole id is in the database before inserting movie#470stephen-riggs merged 3 commits intomainfrom
stephen-riggs merged 3 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 27.06% 26.82% -0.25%
==========================================
Files 78 78
Lines 10293 10486 +193
Branches 1361 1417 +56
==========================================
+ Hits 2786 2813 +27
- Misses 7419 7573 +154
- Partials 88 100 +12 |
Contributor
|
Do you know why this is happening? Seems like a case we just never want to happen |
Contributor
Author
|
I think the third commit on here is probably the answer: it's trying to use the foil hole EPU id, not the murfey db id. |
d-j-hatton
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a condition we have hit on the flush where movies cannot be inserted as the foil hole is not inserted.
This will hopefully ensure that flushed movies only have a foil hole if it is present in the murfey database.