Need frame counts for tomography dose weighting#469
Merged
d-j-hatton merged 4 commits intomainfrom Jan 31, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 27.30% 27.30%
=======================================
Files 78 78
Lines 10164 10169 +5
Branches 1338 1338
=======================================
+ Hits 2775 2777 +2
- Misses 7293 7296 +3
Partials 96 96 |
d-j-hatton
reviewed
Jan 27, 2025
tieneupin
reviewed
Jan 30, 2025
tieneupin
approved these changes
Jan 30, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Just one comment about kV, but otherwise looks ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds frame count finding for tomography, and passes this on to the processing.
Storing the frame count requires a database change, so we may not want to merge this change immediately.