Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 27.06% 27.06%
=======================================
Files 78 78
Lines 10293 10293
Branches 1361 1361
=======================================
Hits 2786 2786
Misses 7419 7419
Partials 88 88 |
tieneupin
approved these changes
Jan 28, 2025
Contributor
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Looks fine, and workflow seems to still work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbcould refer to ispyb or murfey, so it would be clearer to always specifymurfey_db.This PR does not change all the instances, but fixes a bug in the workflows load where some use
dband some usemurfey_db