Register all grid squares and foil holes#455
Merged
stephen-riggs merged 16 commits intomainfrom Jan 22, 2025
Merged
Conversation
This will mean that all foil holes will be recorded, not just those with data associated
… data rather than the metadata
Use the recipes from Murfey configuration rather than hardcoding them. Also, add foil hole ID to preprocessing message during flush.
* Bump version: 0.16.1 → 0.16.2 --------- Co-authored-by: DiamondLightSource-build-server <[email protected]>
…strument server dependencies (#448) * Moves the `_midpoint()` function to `murfey.util.tomo` to keep client and server modules detached * Replaces remaining instances of `procrunner.run()` with `subprocess.run()` * Creates a new key for instrument server package dependencies
* Bump version: 0.16.2 → 0.16.3 * Bump supported client version: 0.16.2 → 0.16.3 --------- Co-authored-by: DiamondLightSource-build-server <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 27.16% 27.08% -0.08%
==========================================
Files 78 78
Lines 10250 10281 +31
Branches 1350 1356 +6
==========================================
+ Hits 2784 2785 +1
- Misses 7378 7408 +30
Partials 88 88 |
stephen-riggs
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register all grid squares and foil holes in
.dmfiles when they are seen. For the grid squares this is the only time this information is available so needs to be done.