Register missed grid squares and foil holes during SPA processing flush#454
Merged
stephen-riggs merged 11 commits intomainfrom Jan 22, 2025
Merged
Register missed grid squares and foil holes during SPA processing flush#454stephen-riggs merged 11 commits intomainfrom
stephen-riggs merged 11 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 27.06% 27.16% +0.09%
==========================================
Files 76 78 +2
Lines 10191 10250 +59
Branches 1345 1350 +5
==========================================
+ Hits 2758 2784 +26
- Misses 7345 7378 +33
Partials 88 88 |
d-j-hatton
reviewed
Jan 21, 2025
Co-authored-by: Daniel Hatton <daniel.hatton@diamond.ac.uk>
d-j-hatton
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a grid square is seen before the data collection group is made, we get an error.
This addresses that by skipping the registration if there is not data collection group, and instead registering any missed grid squares and foil holes when the flush happens.
There's not much really "new" code in here, but a lot of functions have been moved and modified to allow the registration to happen from a client API call or a server call.
client/contexts/spa.pyare now needed by the server, so have moved into theutilfolder (with the exceptions of_grid_square_metadata_filewhich needs to behave differently on the server)api/__init__.pyare now called through the server, so have moved into a workflow.The
flush_spa_processingcall has now moved to a separate workflow. This workflow is also the location of the additions in this PR:flush_spa_processingnow calls a new function_flush_position_analysiswhich fills in any missing grid squares and foil holes in the database.